My first suggestion for picking a race will always be to pick what you want to play, as the racials, at least in PvE content, are all within ~1% of each other. That being said, the clear winner for
Protection, at least in terms of DPS, is
Undead. Damage scaling with hit points on a role that stacks health is already strong enough, paired with the fact that tanks have weaker kits for DPS lowering the value of stat racials, makes it a clear choice. Honorable mention to
Tauren for the 5% HP,
Dwarf for potential
Stoneform shenanigans, and
Night Elf for the strongest snap threat racial.
Horde
Orc
Blood Fury is a strong offensive cooldown and can be paired with
Death Wish and
Recklessness for maximum effect
Hardiness is a pretty solid racial, mostly for PvP, but sometimes in PvE also
Shatter Curse is situationally incredibly strong, removing pesky curses while leveling, and also removing debilitating curses in end-game
Command increases pet damage by 5%, which is useless for Warrior
Orc is a solid pick overall, but not the greatest offensively or defensively
Tauren
War Stomp is strong as an on-demand interrupt, particularly in PvP
Endurance is great for tanking
Plainsrunning is nice quality of life, but becomes pretty useless after your mount at level 40
Cultivation is mostly useless
Tauren is a solid pick if focused solely on tanking and PvP, but weak for dealing damage
Undead
Will of the Forsaken is pretty redundant for a Warrior, as we have multiple fear breaks. Charms and Sleeps are much rarer, mostly occurring in dungeons, where you would want to be grouped with a Shaman who has access to
Tremor Totem
Touch of the Grave can be nice for sustain and 1v1s in PvP, and strong offensively. Slightly better as a dual-wielder
Underwater Breathing is just quality of life and not useful in end-game
Cannibalize is pretty weak for Warriors since we don't benefit from the mana return
Undead is among the strongest races for dealing damage, and the added sustain is nice to have in PvP or leveling
Troll
Berserking, similar to Orcs'
Blood Fury, is a strong offensive cooldown that lines up well with
Death Wish
Regeneration is actually very strong for Warriors as we benefit the most from spirit-based health regeneration, but useless in end-game
Rapid Regeneration is a nice pick-me-up for Warriors while leveling, but its uses are more limited in PvP because you lack crowd control to be able utilize it outside of
Intimidating Shout, and you would have bandages to use anyway
Beast Slaying is actually really nice for leveling, and either useless or overpowered in end-game, depending on whether or not you are hitting a beast
Troll is by far the best Warrior race for leveling, but towards the lower-middle for dealing damage
Skyborne
Wind Blessed provides a strong boost to damage
Elemental Insight isn't super strong as elemental mobs aren't a super popular mob type, but can potentially be incredibly strong in end-game raids
Walk on Air is probably my favorite racial ability, allowing for high jumps and increased mobility
Skysight provides a pretty strong mobility boost
Skyborne is a small amount behind Undead in terms of pure single-target DPS, but the situational increased damage to elementals and movement speed boost puts it slightly ahead in my opinion
Alliance
Human
Ruthless is strong offensively
The Human Spirit is mostly useless in all content
Will to Survive is potentially useful in leveling and PvE content, and very, very strong in PvP
Perception serves no uses in leveling or PvE
Human would be my overall pick for Alliance warrior, being close to Night Elf in damage output, but having a very strong PvP racial to boot
Gnome
Escape Artist is perhaps the strongest racial in the game for PvP
Expansive Mind is mostly useless as reaching the Rage cap will almost never happen
Engineering Specialization is mostly irrelevant
Eureka! can be strong in situations where you've pooled rage prior and used your cooldowns, but does not increase auto attack damage
Gnome is incredibly strong in PvP but noticeably weaker in PvE
Dwarf
Artisan's Precision is very strong while you're below hitcap, and useless when above
Stoneform can be pretty strong while tanking or PvPing vs rogues, priests, feral druids, or other warriors
Find Treasure allows for extra treasure in treasure chests. Mostly useless
Big Game Hunter is pretty nice for leveling, and by far the strongest racial if fighting a beast
Dwarf is on the weaker side offensively and weaker in PvP compared to Gnome or Human
Night Elf
Shadowmeld is a small threat drop in combat and largely useless out of combat
Elune's Light lines up nicely with
Death Wish and is potentially stronger than Human's
Ruthless depending on fight length. Also great for helping to generate snap threat
Quickness is nice for tanking and running around a little bit faster
Wisp Spirit lets you run back to your corpse faster. Useless as we will not be dying ever
Night Elf would be my choice if I were primarily focused on tanking or PvE DPS
Skyborne
Wind Blessed provides a strong boost to damage
Elemental Insight isn't super strong as elemental mobs aren't a super popular mob type, but can potentially be incredibly strong in endgame raids
Walk on Air is probably my favorite racial ability, allowing for high jumps and increased mobility
Read Leyline can be strong for leveling but useless in the end-game
Skyborne is close enough to Human in terms of DPS and potentially much, much better vs Elementals, being a strong choice for PvE. Much weaker in PvP, however